feat: add source-map support for editor DOM mapping#347
Merged
Conversation
Backport the react-source-loc Vite plugin from the app-builder template. The plugin injects `data-source="<file>:<line>:<col>"` attributes onto native JSX elements so the editor can map DOM elements back to their source location. Also enables `sourcemap: true` in the Vite build config. Co-authored-by: Isaac
Collaborator
|
general question, should we add this only on dev and not production builds? |
Register the data-source injection plugin from ViteDevServer so all AppKit apps get editor DOM mapping in dev without a template-local babel plugin. Reimplement with @ast-grep/napi and drop template deps. Signed-off-by: MarioCadenas <MarioCadenas@users.noreply.github.com>
Resolve package.json by keeping magic-string alongside main's get-port and js-yaml deps; regenerate pnpm-lock.yaml. Signed-off-by: MarioCadenas <MarioCadenas@users.noreply.github.com>
… plugin When Vite root is the app root (not client/src/app/frontend), use config.root as projectRoot so data-source paths stay inside the app. Signed-off-by: MarioCadenas <MarioCadenas@users.noreply.github.com>
pkosiec
reviewed
May 20, 2026
Avoid shipping source map files in production client builds while keeping them when NODE_ENV is development. Signed-off-by: MarioCadenas <MarioCadenas@users.noreply.github.com>
ViteDevServer already resolves the app cwd; pass it into reactSourceLocPlugin instead of duplicating nested client dir heuristics that could drift from findClientRoot() candidates. Signed-off-by: MarioCadenas <MarioCadenas@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vite-plugin-react-source-loc.ts— a Vite plugin that injectsdata-source="<file>:<line>:<col>"attributes onto native JSX elements, enabling the editor to map DOM elements back to source locationssourcemap: truein the Vite build config@babel/parser,@babel/traverse, andmagic-stringas devDependenciesBackported from the app-builder template (
universe/apps/app-builder/standalone/packages/app-under-dev).Test plan
databricks apps initproduces a working templatedata-sourceattributes appear on native DOM elements in dev modeThis pull request and its description were written by Isaac.
dev mode
prod mode